32-bit support #232
Merged
32-bit support #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful when building for WASM targets, as well as for legacy systems that run on 32-bit. The relevant code is enabled at compile time by checking the pointer size (__SIZEOF_POINTER__ == 4).
This mainly helps with resolving compiler warnings, and should not have any effective difference, since the relevant struct (RTEPermissionInfo) is not actually used in raw parsing.
lfittl
commented
Dec 30, 2023
| @@ -1272,7 +1272,7 @@ message RTEPermissionInfo | |||
| { | |||
| uint32 relid = 1 [json_name="relid"]; | |||
| bool inh = 2 [json_name="inh"]; | |||
| int64 required_perms = 3 [json_name="requiredPerms"]; | |||
| uint64 required_perms = 3 [json_name="requiredPerms"]; | |||
There was a problem hiding this comment.
As noted in the commit message, this is okay to do only because this struct isn't actually used in raw parse trees. Otherwise this would be an API break (which may be okay in the context of how we use these protobufs, but at least we should talk about doing this outside of major releases).
|
FYI, I tried out this PR and it fixes the problem, all CI tests are green again! |
We've previously managed these in the Makefile inline, but that is very hard to read, and not necessary, since we can simply concatenate the override file to pg_config.h during the source extraction process.
anuraaga
reviewed
Jan 5, 2024
msepga
approved these changes
Jan 9, 2024
|
Just to close the loop, after updating I could remove my 32-bit support patch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231